You should feel happy about it. It shows what you do really attracts attention, and everyone wants to take part in it.
Someone said/did something, and you feel angry. Looks like two events, one led to the other. But something happened in between the two: the first event did something to your mind, and your mind triggered the second event (your feeling angry.) What is that something that was in your mind? Shame? Fear? A reflex ingrained in childhood? Find out.
When someone says something to you, do not dwell on what was said, but ask yourself why it was said.
When he starts nitpicking, acknowledge what he said by repeating it with an even tone to show that you are not emotionally affected. Ask him questions about other parts of your code that you think are important. Have the questions ready ahead of time.
His nitpicking may be his way to put you down. So, if you get upset, he has succeeded.
What's on the surface is often a compensation for what is underneath. So, what does his "loudness" try to distract you from?
Be always respectful. But don't take the two too seriously. Ask yourself what you need out of this job besides the paycheck. A sense of worthiness? A sense of belonging? Make sure you are not looking for things where they don't exist or misplaced. Your worthiness is inside you, not a gift from others.
2)公司规定要code review的话,你请别人review,把那俩人束之高阁,如果他们跑来要review,你的回答永远是,“不用,同事已经在review了,谢谢”。 如果他问你为啥不请他review,你的回答是 “为什么一定要是你?” 千万别是 “然后他就很生气我没给他review,我说你当然可以review了”. This is a big no no. 一个原则你一定要把握住就是, 你叫谁来review你的code,谁才可以来review, 而不是”你当然可以review了“。
3)如果他不管三七二十一,自行review并改你的code,你到最后一并全部在source control system里面reverse back, 并在commit的message里写下类似如下等评语, e.g. unnecessary change, useless, meaningless, hard to maintain, very risky change。。。 等等等等。 (TMD真想写上stupid and incompetent)
他经常修改我的code部分,很少给我review,和另外一个同事是狼狈为奸似的,他们两个都是那种咄咄逼人的那种人,好象什么都得他们说了算,别人都不太敢惹他们,但他们俩又互相忌惮,对对方不像对别人那样,所以组里就好像他们俩说了算。特别这几天他们俩就商量着改我完成的一部分code,改了就相互review,当我空气。然后今天我写的code和他的code有关联,但其实关系也不大,我就让另外一个同事review了,其实我一般也不喜欢让他review,因为他总是那种鸡蛋里挑骨头的态度。然后他就很生气我没给他review,我说你当然可以review了,然后他就开始各种挑剔,说我不尊重他的code,我也非常生气,就跟他吵起来了。这世道哪儿都是欺软怕硬,组里其他人对他们俩也是敢怒不敢言,反倒好像讨好着他们。一帮大男人有时被他俩怼得跟孩子做错了事似的,我都替他们生气,今天我和他争论也没人敢吭声。其实组里其他人还都挺好,就这两个人让我觉得特不舒服,都不想干了!
NASDAQ 涨势不减,美国经济走出低谷,而代表IT业的S&P500持续低迷,IT就业市场继续走低,裁员减薪趋势不可逆当!
IT学子用垂不朽!
如果没有规范,应该和领导反应建立一个规范,代码review提问题要有依据,否则就变成一团乱账。这样能彻底解决问题,谁也不用受气,包括你的同事。
You should feel happy about it. It shows what you do really attracts attention, and everyone wants to take part in it.
Someone said/did something, and you feel angry. Looks like two events, one led to the other. But something happened in between the two: the first event did something to your mind, and your mind triggered the second event (your feeling angry.) What is that something that was in your mind? Shame? Fear? A reflex ingrained in childhood? Find out.
When someone says something to you, do not dwell on what was said, but ask yourself why it was said.
When he starts nitpicking, acknowledge what he said by repeating it with an even tone to show that you are not emotionally affected. Ask him questions about other parts of your code that you think are important. Have the questions ready ahead of time.
His nitpicking may be his way to put you down. So, if you get upset, he has succeeded.
What's on the surface is often a compensation for what is underneath. So, what does his "loudness" try to distract you from?
Be always respectful. But don't take the two too seriously. Ask yourself what you need out of this job besides the paycheck. A sense of worthiness? A sense of belonging? Make sure you are not looking for things where they don't exist or misplaced. Your worthiness is inside you, not a gift from others.
你们改我的code的时候,有尊重我和跟我review吗?没有吧。既然你们可以这样做,这就是rule(规矩)。我也是照规矩办事嘛
我一般不理他们。他们主动找上门,我也不甘示弱,该堵堵回去。你可以问他别人不能review吗?对这样的要不卑不亢。
code review不是鸡蛋里挑骨头, 而是对半成品的抛光和打磨。 谈不上对个人的攻击, 谈不上几人一伙狼狈为奸搞派系斗争。
你的观点着眼于个人斗争与面子, 从技术观点上讲, 眼界与格局还有提高的空间。
between 人的攻击 and 对半成品的抛光和打磨? You do not mean there is no 人的攻击 or 鸡蛋里挑骨头 in working place, right?
code review说到底还是positive的, 挑出的问题越多对作者的advantage越大。
真正的斗争是抢夺资源, 限制别人接触重要项目,或者take credit, 将别人的成果说成自己的。还有挑拨离间造成别的同事之间矛盾的, 还有处于相同利益一方的人联合起来制造谣言, 对敌对方进行个人攻击的。
如果他有权改你无话可说,将来有错都有记录的
如果他自说自话改,给以警告
1. 如楼下hz82000所说,先搞清楚你们公司 review,改代码的章程。
2. 找三个张三从前只挑错,没建议的例子。
3. 约老板谈。如贴中所说“吵”起来了,老板肯定知道。你不去与老板谈,自己先没了理。谈的时候:
全组是否敢怒不敢言只是楼主的主观判断。职场聚众闹事不是这么个闹法,结果是群众都跑了。
老板是甩手掌柜,懒得管你们。 2)你们工作蛮清闲的,是政府吗?如果是私影公司,TC不错的话很难得呀,你肯定不愿意走,哈哈哈。
code review一般是作者请誰review,谁就review,也没有什么太硬性的规定,都是professional嘛,不过碰上你们那俩个不懂味+不遵重他人的,你只能酱子了 -
1)review时间别留太多,你写完code了先压着,玩去,到最后才checkin
2)公司规定要code review的话,你请别人review,把那俩人束之高阁,如果他们跑来要review,你的回答永远是,“不用,同事已经在review了,谢谢”。 如果他问你为啥不请他review,你的回答是 “为什么一定要是你?” 千万别是 “然后他就很生气我没给他review,我说你当然可以review了”. This is a big no no. 一个原则你一定要把握住就是, 你叫谁来review你的code,谁才可以来review, 而不是”你当然可以review了“。
3)如果他不管三七二十一,自行review并改你的code,你到最后一并全部在source control system里面reverse back, 并在commit的message里写下类似如下等评语, e.g. unnecessary change, useless, meaningless, hard to maintain, very risky change。。。 等等等等。 (TMD真想写上stupid and incompetent)
4) 他要是像幼儿园小朋友一样哭着跑去老板那告状,正好,那你可有得说了。你老板要是个甩手掌柜,估计压根懒得管。
assertTrue(”xxx那丫的名字” == “stupid”); 让丫看去吧